Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch install on FreeBSD using pkgng #48730

Merged
merged 4 commits into from Aug 2, 2018

Conversation

Projects
None yet
3 participants
@fzipi
Copy link
Contributor

commented Jul 24, 2018

For fully automated batch installing in FreeBSD you need to pass BATCH=true.

What does this PR do?

Add a new option to pkg install, batch=True.

What issues does this PR fix or reference?

#27056, #29907, #29909

Previous Behavior

When installing postfix in FreeBSD, it keeps asking for confirmation to change mailer.conf. When using the postfix formula, it does not work because installation is not automated (you can break things in production, etc.).

New Behavior

Installation is succesful. You may require to configure additional steps, but at least the package is there.

Tests written?

No

Commits signed with GPG?

Yes

Fix batch install using pkgng
For fully automated batch installing in FreeBSD you need to pass BATCH=true.

@salt-jenkins salt-jenkins requested a review from saltstack/team-suse Jul 24, 2018

fzipi added some commits Jul 24, 2018

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2018

Welcome @fzipi! Thank you for submitting this. This looks good to me, but I'm not super familiar with FreeBSD.

@abednarik You've been involved with FreeBSD support - can you review this?

@abednarik

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2018

@abednarik

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2018

Hi @rallytime

This looks good to me.

Thanks.

@rallytime rallytime merged commit 1520bd4 into saltstack:develop Aug 2, 2018

6 of 9 checks passed

jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
continuous-integration/jenkins/pr-merge This commit is being built
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
WIP ready for review
Details
codeclimate 1 fixed issue
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

rallytime added a commit that referenced this pull request Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.