Add a few functions for network configuration manipulation#48739
Merged
rallytime merged 1 commit intosaltstack:developfrom Jul 26, 2018
Merged
Add a few functions for network configuration manipulation#48739rallytime merged 1 commit intosaltstack:developfrom
rallytime merged 1 commit intosaltstack:developfrom
Conversation
ab15960 to
e026451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I am adding a few handy functions to the existing
netmodule, for feature parity with the file module. It actually uses the corresponding functions fromfile, loading the result on the network device. As far as I know, besides Junos, no other network platform supports configuration replace natively. With this functions, we don't need to worry about that anymore, as the operation is done on the system side where we have (almost) unlimited flexibility: download the configuration from the network device, apply the patch, and finally load the result.This helped me cleanup many inconsistent parts of the config (as very frequently a chunk of configuration may be referenced in multiple places), e.g., when converting the name of some prefix lists from upper to lower: