New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os.uname is not available on py2 windows #48756

Merged
merged 1 commit into from Jul 24, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Contributor

dwoz commented Jul 24, 2018

What does this PR do?

Fixes multiple failing tests under unit.grains.test_core

https://jenkinsci.saltstack.com/job/2018.3/job/salt-windows-2016-py2/109/

Tests written?

No - Fixing existing test cases

Commits signed with GPG?

Yes

@dwoz dwoz requested review from rallytime and twangboy Jul 24, 2018

@dwoz dwoz force-pushed the dwoz:core_grains_fix branch from b57be58 to b7a37ec Jul 24, 2018

@dwoz dwoz merged commit 8aef6d9 into saltstack:2018.3 Jul 24, 2018

4 of 8 checks passed

jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details

@dwoz dwoz deleted the dwoz:core_grains_fix branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment