Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Two new features for the napalm configuration management: commit_in and commit_at #48779
What does this PR do?
In the networking world, there are a very small number of platforms that allow you to commit a specific configuration change at a desired time. Although this is not particularly one of the best practices, turns out to be important sometimes (very rarely though). Nevertheless it is and will forever be optional.
With these changes, I am adding support for
For safety reasons, I am adding the
# salt veos net.load_config text='ntp server 188.8.131.52' commit_in=2m veos: ---------- already_configured: False comment: Changes discarded for now, and scheduled commit at: 2018-07-26T10:06:33. The commit ID is: 20180726100429648495. To discard this commit, you can execute: salt veos net.cancel_commit 20180726100429648495 diff: @@ -5,6 +5,7 @@ transceiver qsfp default-mode 4x10G ! ntp server 184.108.40.206 +ntp server 220.127.116.11 ntp server 18.104.22.168 ntp server 10.10.10.1 ! loaded_config: result: True
Hi @mirceaulinic - this is causing some related tests to fail. Can you take a look?
@mirceaulinic There are 2 tests failing with this change: