New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linting docs to contain .testing.pylintrc use #48795

Merged
merged 1 commit into from Jul 27, 2018

Conversation

Projects
None yet
2 participants
@rallytime
Contributor

rallytime commented Jul 27, 2018

The PR tests use the .testing.pylintrc file, rather than the more restrictive .pylintrc file. This can be a point of confusion when following the current documentation.

The docs should reference the testing file and that the Jenkins PR tests use .testing.pylintrc instead of .pylintrc.

Fixes #48417

Update linting docs to contain .testing.pylintrc use
The PR tests use the ``.testing.pylintrc`` file, rather than the
more restrictive ``.pylintrc`` file. This can be a point of confusion
when following the current documentation.

The docs should reference the testing file and that the Jenkins PR
tests use ``.testing.pylintrc`` instead of ``.pylintrc``.

Fixes #48417

@rallytime rallytime requested a review from saltstack/team-core Jul 27, 2018

@rallytime rallytime merged commit d74f47b into saltstack:2017.7 Jul 27, 2018

4 of 8 checks passed

jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details

@rallytime rallytime deleted the rallytime:fix-48417 branch Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment