Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support for execution modules and states mount on AIX #48803
What does this PR do?
Provides support for mount on AIX for execution modules and states
What issues does this PR fix or reference?
mount.active functioned on AIX
Full support for mount functionality in execution modules and states on AIX
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
Updated for review comments. Note the changes to salt/utils/files.py flock and use of LOCK_EX.
The use of LOCK_SH has been present in Salt since 2013, so this change may cause unanticipated affects. Please review this section carefully.
@rallytime Not seeing test_mount failures with:
On both Centos 7 7.3 and update to latest 7.5.1804
Do see 2 failures on both versions of Centos 7
Running with VirtualBox rather than Docker and Kitchen etc. Believe issues seen are related to environment than unit tests.
If you still can't reproduce, you should be able to get a matching environment with kitchen-salt. @gtmanfred should be able to point you in the right direction.
@rallytime I am very suspect that we are looking at a docker issue of some sort given VM's are a better abstraction of a machine. However understand the need to get it working with testing and will check with Daniel to resolve the issue with automatic testing, noting that both Debian 8 and Redhat 7 (7.3 and 7.5) pass fine on a VM.