New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use brew path from which cmd in mac_brew module #48804

Merged
merged 2 commits into from Jul 31, 2018

Conversation

Projects
None yet
3 participants
@Ch3LL
Contributor

Ch3LL commented Jul 27, 2018

What does this PR do?

see issue saltstack/salt-jenkins#1033 for details.

after this fix #47212 we aren't passing the PATH via the env anymore so we need to run which brew to get the entire path or else we see this error:

salt-call --local pkg.install vim
[ERROR   ] stderr: -bash: brew: command not found
[ERROR   ] retcode: 127
Error running 'pkg.install': Brew command failed. Additional info follows:

result:
    ----------
    pid:
        55236
    retcode:
        127
    stderr:
        -bash: brew: command not found
    stdout:

also note: brew tests still will not pass until #48796 is merged

fyi @weswhet

@weswhet

This comment has been minimized.

Contributor

weswhet commented Jul 27, 2018

LGTM thanks!

@rallytime rallytime merged commit 3d16a63 into saltstack:2018.3 Jul 31, 2018

5 of 8 checks passed

jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment