Ability to set permissions in the Windows Registry #48832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking for aces you always got the non-inherited aces Now it shows both types
ghost
self-requested a review
Contributor
|
A change like this is going to need some test coverage. |
rallytime
added
the
needs-testcase
It was there in the docs, just missing from the code
rallytime
removed
the
needs-testcase
Contributor
Author
|
@rallytime I am writing tests. Hence the WIP |
twangboy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds ability to modify the DACL to the
win_regmodule.Moves some shared functions to the
win_daclsalt util.Fixes documentation formatting and spelling
Fixes an issue with resetting inherited and non inherited permissions
What issues does this PR fix or reference?
#44126
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Tests written?
Yes/No
Commits signed with GPG?
Yes