Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set permissions in the Windows Registry #48832

Merged
merged 15 commits into from Aug 5, 2018

Conversation

twangboy
Copy link
Contributor

What does this PR do?

Adds ability to modify the DACL to the win_reg module.
Moves some shared functions to the win_dacl salt util.
Fixes documentation formatting and spelling
Fixes an issue with resetting inherited and non inherited permissions

What issues does this PR fix or reference?

#44126

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Tests written?

Yes/No

Commits signed with GPG?

Yes

@ghost ghost self-requested a review July 31, 2018 00:08
@rallytime
Copy link
Contributor

A change like this is going to need some test coverage.

@rallytime rallytime added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Jul 31, 2018
@rallytime rallytime removed the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Aug 1, 2018
@twangboy
Copy link
Contributor Author

twangboy commented Aug 1, 2018

@rallytime I am writing tests. Hence the WIP

@twangboy twangboy changed the title [WIP] Ability to set permissions in the Windows Registry Ability to set permissions in the Windows Registry Aug 1, 2018
@twangboy twangboy requested a review from dwoz August 1, 2018 23:08
Copy link
Contributor

@rallytime rallytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

LGTM. Thank you for writing tests and I love it when we can consolidate code like this. Well done.

I'd like someone more familiar with Windows, like @dwoz to review this, but from my perspective this looks good.

@rallytime rallytime added the ZRELEASED - Fluorine reitred label label Aug 2, 2018
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, approved.

@rallytime rallytime merged commit 22d85ee into saltstack:develop Aug 5, 2018
@twangboy twangboy deleted the reg_dacl branch August 23, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants