Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set permissions in the Windows Registry #48832

Merged
merged 15 commits into from Aug 5, 2018

Conversation

Projects
None yet
3 participants
@twangboy
Copy link
Contributor

commented Jul 31, 2018

What does this PR do?

Adds ability to modify the DACL to the win_reg module.
Moves some shared functions to the win_dacl salt util.
Fixes documentation formatting and spelling
Fixes an issue with resetting inherited and non inherited permissions

What issues does this PR fix or reference?

#44126

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Tests written?

Yes/No

Commits signed with GPG?

Yes

twangboy added some commits Jul 30, 2018

Fix issue with list_aces and get_aces
When checking for aces you always got the non-inherited aces
Now it shows both types

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Jul 31, 2018

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2018

A change like this is going to need some test coverage.

twangboy added some commits Jul 31, 2018

Add missing exact option to has_permission function
It was there in the docs, just missing from the code
@twangboy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2018

@rallytime I am writing tests. Hence the WIP

twangboy added some commits Aug 1, 2018

@twangboy twangboy changed the title [WIP] Ability to set permissions in the Windows Registry Ability to set permissions in the Windows Registry Aug 1, 2018

twangboy added some commits Aug 1, 2018

@twangboy twangboy requested a review from dwoz Aug 1, 2018

@rallytime
Copy link
Contributor

left a comment

👍

LGTM. Thank you for writing tests and I love it when we can consolidate code like this. Well done.

I'd like someone more familiar with Windows, like @dwoz to review this, but from my perspective this looks good.

@rallytime rallytime added the Fluorine label Aug 2, 2018

@dwoz

dwoz approved these changes Aug 2, 2018

Copy link
Contributor

left a comment

Looks nice, approved.

@rallytime rallytime merged commit 22d85ee into saltstack:develop Aug 5, 2018

6 of 9 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
codeclimate 56 issues to fix
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@twangboy twangboy deleted the twangboy:reg_dacl branch Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.