New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: added additional return code 200 for succeeded vault api request #48838

Merged
merged 1 commit into from Jul 31, 2018

Conversation

Projects
None yet
3 participants
@sizgiyaev
Contributor

sizgiyaev commented Jul 31, 2018

What does this PR do?

Adds an additional successful return code from the Vault API. The API also responses with HTTP code 200 when the request for changes is successful, not only 204.

What issues does this PR fix or reference?

The vault.policy_preset state returns failed status even if the API request is succeeded.

Previous Behavior

vault.policy_preset state returns a failed status even if the API request is succeeded.

New Behavior

vault.policy_preset state returns a success status due to a succeeded API request.

Tests written?

No

Commits signed with GPG?

No

@sizgiyaev

This comment has been minimized.

Contributor

sizgiyaev commented Jul 31, 2018

continuous-integration/jenkins/pr-merge is failed, but doesn't look to be related to my changes

@rallytime rallytime requested a review from gtmanfred Jul 31, 2018

@rallytime rallytime merged commit 5e14e36 into saltstack:2018.3 Jul 31, 2018

5 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
@rallytime

This comment has been minimized.

Contributor

rallytime commented Jul 31, 2018

Yeah, that's fine. Welcome @sizgiyaev! Thank you for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment