New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent u'something' to appear in help info. #48843

Merged
merged 2 commits into from Aug 1, 2018

Conversation

Projects
None yet
4 participants
@isbm
Contributor

isbm commented Jul 31, 2018

What does this PR do?

In order to quote level names in --help for logging, repr() was used. This resulted to u'....' in Python 3.

What issues does this PR fix or reference?

Removes u in front.

@isbm

This comment has been minimized.

Contributor

isbm commented Jul 31, 2018

@rallytime @terminalmage here is the second take.

@rallytime rallytime requested a review from terminalmage Jul 31, 2018

@rallytime rallytime merged commit bec79e8 into saltstack:2018.3 Aug 1, 2018

6 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@isbm isbm deleted the isbm:isbm-log-level-names-fix-2 branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment