Add module for Cisco IOS configuration manipulation #48859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rallytime
suggested changes
Aug 1, 2018
Contributor
rallytime
left a comment
rallytime
left a comment
There was a problem hiding this comment.
I have 2 small requests. Thank you for writing tests for this! 🎉
There's also a pylint warning.
salt/modules/iosconfig.py
Outdated
|
|
||
| # Import python stdlib | ||
| import difflib | ||
| from collections import OrderedDict |
Contributor
There was a problem hiding this comment.
This should use the OrderedDicrt from salt.utils.odict.
tests/unit/modules/test_iosconfig.py
Outdated
|
|
||
| # Import Python libs | ||
| import textwrap | ||
| from collections import OrderedDict |
Contributor
Author
|
Wasn't aware of |
Contributor
|
@mirceaulinic Can you fix the lint error too? https://jenkinsci.saltstack.com/job/pr-lint/job/PR-48859/2/warnings52Result/ |
Contributor
Author
|
Alright, seems like ca254fb fixed the lint. |
rallytime
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new module for Cisco IOS style configuration manipulation, and use the functionality into the NAPALM module to have the features directly applied on the configuration(s) of the managed device.