Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module for Cisco IOS configuration manipulation #48859

Merged
merged 6 commits into from Aug 2, 2018

Conversation

Projects
None yet
2 participants
@mirceaulinic
Copy link
Member

commented Aug 1, 2018

What does this PR do?

Adds a new module for Cisco IOS style configuration manipulation, and use the functionality into the NAPALM module to have the features directly applied on the configuration(s) of the managed device.

@rallytime
Copy link
Contributor

left a comment

I have 2 small requests. Thank you for writing tests for this! 🎉

There's also a pylint warning.


# Import python stdlib
import difflib
from collections import OrderedDict

This comment has been minimized.

Copy link
@rallytime

rallytime Aug 1, 2018

Contributor

This should use the OrderedDicrt from salt.utils.odict.


# Import Python libs
import textwrap
from collections import OrderedDict

This comment has been minimized.

Copy link
@rallytime

rallytime Aug 1, 2018

Contributor

Same comment here. :)

@mirceaulinic

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2018

Wasn't aware of salt.utils.odict (or probably I forgot) - should be fixed via 062f161 @rallytime.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2018

@mirceaulinic

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

Alright, seems like ca254fb fixed the lint.

@rallytime rallytime merged commit 93c5955 into saltstack:develop Aug 2, 2018

7 of 9 checks passed

codeclimate 20 issues to fix
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.