Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution module to SCP files on devices where we can't install the Salt Minion #48861

Merged
merged 3 commits into from Aug 6, 2018

Conversation

@mirceaulinic
Copy link
Member

@mirceaulinic mirceaulinic commented Aug 1, 2018

What does this PR do?

This is one of the major downsides of managing devices (such as network gear) where we can't install the Salt Minion and use salt-cp.
This module can be used alone, as-is, but it will be used in future modules and states such as upgrading the firmware on network devices, etc.

@rallytime
Copy link
Contributor

@rallytime rallytime commented Aug 2, 2018

Hey @mirceaulinic - There's a merge conflict on this PR. Can you rebase?

@mirceaulinic
Copy link
Member Author

@mirceaulinic mirceaulinic commented Aug 3, 2018

Rebased and fixed the conflicts now @rallytime - thanks!

dwoz
dwoz approved these changes Aug 5, 2018
Copy link
Contributor

@rallytime rallytime left a comment

One request from me. :)

Module to copy files via `SCP <https://man.openbsd.org/scp>`_
'''
from __future__ import absolute_import
Copy link
Contributor

@rallytime rallytime Aug 5, 2018

This needs print_function and unicode_literals.

Copy link
Member Author

@mirceaulinic mirceaulinic Aug 5, 2018

Oh, sorry I always forget them.

Copy link
Member Author

@mirceaulinic mirceaulinic Aug 5, 2018

Added now

recursive=False,
preserve_times=False,
saltenv='base',
**kwargs):
Copy link
Contributor

@cachedout cachedout Aug 5, 2018

Reading the docs here, it's not clear what kwargs could be passed here and what effect they would have.

Copy link
Member Author

@mirceaulinic mirceaulinic Aug 5, 2018

Good point - I will add some docs on this. Thanks for suggestion!

Copy link
Member Author

@mirceaulinic mirceaulinic Aug 5, 2018

I added some more notes into the docstring of these functions, please let me know what you think!

@rallytime rallytime merged commit c0dde8e into saltstack:develop Aug 6, 2018
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants