Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution module to SCP files on devices where we can't install the Salt Minion #48861

Merged
merged 3 commits into from Aug 6, 2018

Conversation

Projects
None yet
5 participants
@mirceaulinic
Copy link
Member

commented Aug 1, 2018

What does this PR do?

This is one of the major downsides of managing devices (such as network gear) where we can't install the Salt Minion and use salt-cp.
This module can be used alone, as-is, but it will be used in future modules and states such as upgrading the firmware on network devices, etc.

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2018

Hey @mirceaulinic - There's a merge conflict on this PR. Can you rebase?

@mirceaulinic mirceaulinic force-pushed the mirceaulinic:scp-mod branch from a9fd27f to 11daf33 Aug 3, 2018

@mirceaulinic

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2018

Rebased and fixed the conflicts now @rallytime - thanks!

@rallytime rallytime added the Fluorine label Aug 3, 2018

@rallytime rallytime requested a review from saltstack/team-core Aug 5, 2018

@dwoz

dwoz approved these changes Aug 5, 2018

@rallytime
Copy link
Contributor

left a comment

One request from me. :)

Module to copy files via `SCP <https://man.openbsd.org/scp>`_
'''
from __future__ import absolute_import

This comment has been minimized.

Copy link
@rallytime

rallytime Aug 5, 2018

Contributor

This needs print_function and unicode_literals.

This comment has been minimized.

Copy link
@mirceaulinic

mirceaulinic Aug 5, 2018

Author Member

Oh, sorry I always forget them.

This comment has been minimized.

Copy link
@mirceaulinic

mirceaulinic Aug 5, 2018

Author Member

Added now

recursive=False,
preserve_times=False,
saltenv='base',
**kwargs):

This comment has been minimized.

Copy link
@cachedout

cachedout Aug 5, 2018

Collaborator

Reading the docs here, it's not clear what kwargs could be passed here and what effect they would have.

This comment has been minimized.

Copy link
@mirceaulinic

mirceaulinic Aug 5, 2018

Author Member

Good point - I will add some docs on this. Thanks for suggestion!

This comment has been minimized.

Copy link
@mirceaulinic

mirceaulinic Aug 5, 2018

Author Member

I added some more notes into the docstring of these functions, please let me know what you think!

@mirceaulinic mirceaulinic force-pushed the mirceaulinic:scp-mod branch from 11daf33 to 419d0cb Aug 5, 2018

@rallytime rallytime merged commit c0dde8e into saltstack:develop Aug 6, 2018

4 of 5 checks passed

codeclimate 5 issues to fix
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.