Add execution module to SCP files on devices where we can't install the Salt Minion#48861
Merged
Conversation
Contributor
|
Hey @mirceaulinic - There's a merge conflict on this PR. Can you rebase? |
Contributor
Author
|
Rebased and fixed the conflicts now @rallytime - thanks! |
dwoz
approved these changes
Aug 5, 2018
rallytime
reviewed
Aug 5, 2018
Contributor
rallytime
left a comment
rallytime
left a comment
There was a problem hiding this comment.
One request from me. :)
Contributor
There was a problem hiding this comment.
This needs print_function and unicode_literals.
Contributor
Author
There was a problem hiding this comment.
Oh, sorry I always forget them.
cachedout
reviewed
Aug 5, 2018
Contributor
There was a problem hiding this comment.
Reading the docs here, it's not clear what kwargs could be passed here and what effect they would have.
Contributor
Author
There was a problem hiding this comment.
Good point - I will add some docs on this. Thanks for suggestion!
Contributor
Author
There was a problem hiding this comment.
I added some more notes into the docstring of these functions, please let me know what you think!
terminalmage
approved these changes
Aug 6, 2018
rallytime
approved these changes
Aug 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is one of the major downsides of managing devices (such as network gear) where we can't install the Salt Minion and use
salt-cp.This module can be used alone, as-is, but it will be used in future modules and states such as upgrading the firmware on network devices, etc.