Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add cmd module integration tests for windows and fix space in path issue #48866
What does this PR do?
Adds the cmdmod module integration tests to run on windows and fixes an issue on windows when there is a space in the path name of the
Given this state file:
When run I see this error:
If i use the powershell shell it works:
The reason this is occurring is because it tries to escape the quotes around the command leaving hte space unescaped. So the resulting command is this:
Also fixes an issue when it it attempts to clean the temp file here: https://github.com/saltstack/salt/blob/v2017.7.7/salt/modules/cmdmod.py#L2141
it cannot delete the temp file because it quotes the path
Also this PR changes the expected return in windows on the tests so I could use some review if those returns are expected behavior or not.
What issues does this PR fix or reference?
Yes - adds tests and fixes something a test found
Commits signed with GPG?