New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unicode key pairs from environ after test #48871

Merged
merged 2 commits into from Aug 1, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Contributor

dwoz commented Aug 1, 2018

What does this PR do?

Fixes failure in test setUp method:

https://jenkinsci.saltstack.com/job/2018.3/job/salt-windows-2016-py2/3/testReport/junit/setUpClass%20(unit.fileserver/test_gitfs/GitPythonTest_/

This PR fixes the above error by removing unicode values added to the environment from other test cases. This just makes sure the other test removes what it added to the environment.

Tests written?

No - Fixing tests

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from gtmanfred Aug 1, 2018

@dwoz dwoz merged commit d4bb3a0 into saltstack:2018.3 Aug 1, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/lint The lint job has passed
Details

@dwoz dwoz deleted the dwoz:test_cleanup branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment