New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IP_LEARNING optional #48876

merged 1 commit into from Aug 2, 2018


None yet
2 participants

Vaelatern commented Aug 2, 2018

What does this PR do?

Not always put a certain piece of XML in place, depending on how we intend to learn the network address.

What issues does this PR fix or reference?

In a network with one VM serving dhcp addresses, and other VMs connecting to it, the following problems were observed:

  • Issue observed where in libvirt 4.4.0 the filterref block would ignore dhcp if set to 'any'.
  • Issue observed where in libvirt 4.5.0 (latest at time of writing) the filterref block would permit the client to get an address, but then not permit any more traffic.

Previous Behavior

Always make sure the filterref xml clause is added to the network configuration.

New Behavior

If ip_source is not ip-learning (or blank, defaults to ip-learning), then don't alter the vm network configuration beyond removing the MAC address.

Tests written?


Commits signed with GPG?


@salt-jenkins salt-jenkins requested a review from saltstack/team-cloud Aug 2, 2018



@rallytime rallytime merged commit e79ccb3 into saltstack:2017.7 Aug 2, 2018

5 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
WIP ready for review
jenkins/pr/docs The docs job has passed
jenkins/pr/lint The lint job has passed
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed

@Vaelatern Vaelatern deleted the Vaelatern:make-network-learning-optional branch Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment