New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_pkg: Fix issue introduced in Jan 2018 DisplayVersion missing should result… #48891

Merged
merged 1 commit into from Aug 5, 2018

Conversation

Projects
None yet
4 participants
@damon-atkins
Member

damon-atkins commented Aug 2, 2018

What does this PR do?

Fix a unintended behavioural change Jan 2018.

What issues does this PR fix or reference?

Windows packages are hidden in pkg.list_pkgs if they have no DisplayVersion #48865

Previous Behavior

Packages without DisplayVersion are skipped.

New Behavior

Packages without DisplayVersion, version is returned as "Not Found"

Tests written?

No

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested review from saltstack/team-windows Aug 2, 2018

@damon-atkins damon-atkins force-pushed the damon-atkins:2017.7_win_pkg.list_pkgs_not_found branch from 6319dd4 to b926df0 Aug 2, 2018

Fix win_pkg issues introduced Jan 2018. If DisplayVersion does not ex…
…ist it should return version as "Not Found"

@damon-atkins damon-atkins force-pushed the damon-atkins:2017.7_win_pkg.list_pkgs_not_found branch from a25bb13 to a4af1db Aug 2, 2018

@damon-atkins

This comment has been minimized.

Member

damon-atkins commented Aug 3, 2018

Looks like the lint passed, but still return an error to Jenkins.

@damon-atkins

This comment has been minimized.

Member

damon-atkins commented Aug 3, 2018

re-run lint

@damon-atkins

This comment has been minimized.

Member

damon-atkins commented Aug 3, 2018

Ready to be merged.

@rallytime rallytime merged commit d541bd6 into saltstack:2017.7 Aug 5, 2018

6 of 8 checks passed

jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details

@damon-atkins damon-atkins deleted the damon-atkins:2017.7_win_pkg.list_pkgs_not_found branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment