Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[2018.3] fix to auth/ldap.py #48901
What does this PR do?
Fixing issue when a valid token is generated by the salt-api even when invalid user credentials are passed. This change verifies that the binddn credentials are valid, then verifies that the username & password (if not None) are also valid.
What issues does this PR fix or reference?
When binddn credentials are included in the configuration, a valid token is generated by the salt-api regardless of whether the username & password is valid.
If binddn credentials are configured, first the binddn credentials are verified and if they are valid, then the username & password credentials are verified.
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.