New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap ElementTree.tostring to make strs, not bytes #48903

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
3 participants
@Vaelatern
Contributor

Vaelatern commented Aug 3, 2018

What does this PR do?

It's the requested followup to #48877

What issues does this PR fix or reference?

See #48877

Previous Behavior

Unknown, but this seems to be another place where strings are wanted.

New Behavior

Hopefully it works, have not been able to test outright.

Tests written?

No

Commits signed with GPG?

No

@rallytime

This comment has been minimized.

Contributor

rallytime commented Aug 3, 2018

@rares-pop

This comment has been minimized.

Contributor

rares-pop commented Aug 3, 2018

The change looks good, but do we want it in develop too? There are more instances to be changed.

@rallytime

This comment has been minimized.

Contributor

rallytime commented Aug 3, 2018

@rares-pop It will be merged-forward into develop. I just realized the fix was against 2018.3. 👍

@rallytime rallytime merged commit f1adf56 into saltstack:2018.3 Aug 3, 2018

4 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details

@Vaelatern Vaelatern deleted the Vaelatern:improve-salt-cloud-python3-virt branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment