New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No rehashing in parallel #48904

Merged
merged 2 commits into from Aug 3, 2018

Conversation

Projects
None yet
4 participants
@KaiSforza
Contributor

KaiSforza commented Aug 3, 2018

Rehashing in parallel causes pyenv to fail, if they're run at almost the
exact same time. It's breaking our lint tests pretty horribly.

What does this PR do?

Allows our lint tests to pass

Previous Behavior

Lint tests would fail in either salt linting or test linting during the rehash.

New Behavior

Tests pass.

@gtmanfred @dubb-b

No rehashing in parallel
Rehashing in parallel causes pyenv to fail, if they're run at almost the
exact same time. It's breaking our lint tests pretty horribly.
@dubb-b

dubb-b approved these changes Aug 3, 2018

@rallytime rallytime requested a review from gtmanfred Aug 3, 2018

@gtmanfred

PR lint is failing, rerunning.

@gtmanfred gtmanfred merged commit 734f82c into saltstack:develop Aug 3, 2018

3 of 9 checks passed

continuous-integration/jenkins/pr-merge This commit is being built
Details
jenkins/pr/lint Testing lint...
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/pr/docs The docs job has passed
Details

gtmanfred added a commit that referenced this pull request Aug 3, 2018

gtmanfred added a commit that referenced this pull request Aug 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment