Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add napalm commit confirmed features #48909
What does this PR do?
In line with my previous PR #48779, adding now two new features
The main problem is not the naming nevertheless, but the fact that not all the platforms support this natively (only Junos AFAIK). However, via Salt this would be available on any platform, but with some caveats and the user must be very cautious when using this (not that the feature itself can cause issues, but to have the right expectations when using this).
$ sudo salt veos-lab net.load_config text='ntp server 172.17.17.2' revert_in=2m veos-lab: ---------- already_configured: False comment: The commit ID is: 20180802145541882500. This commit will be reverted at: 2018-08-02T14:57:49, unless confirmed. To confirm the commit and avoid reverting, you can execute: salt veos-lab net.confirm_commit 20180802145541882500 diff: @@ -5,6 +5,7 @@ transceiver qsfp default-mode 4x10G ! ntp server 172.17.17.1 +ntp server 172.17.17.2 ! snmp-server location Tampa, FL ! loaded_config: result: True $ sudo salt veos-lab net.confirm_commit 20180802145541882500 veos-lab: ---------- comment: Commit #20180802145541882500 confirmed. result: True
With this PR, I am also: