Update Netbox execution module

[Ichabond]

What does this PR do?

Add multiple functions to interact with the Netbox API.

New Behavior

This PR adds more functions to the Netbox execution module. This further expands the functionality by allowing deletion and creation of Netbox objects as well.

Tests written?

No

Commits signed with GPG?

No

CC: @zachmoody @mirceaulinic

[gtmanfred]

instead of using salt.utils.args.clean_kwargs, it is already injected in these modules, just use __utils__['args.clean_kwargs'](**kwargs)

[Ichabond]

I've updated this, but this breaks the unit tests:

Traceback (most recent call last):
  File "/Users/tstrickx/Library/Python/2.7/lib/python/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "/Users/tstrickx/Documents/Projects/salt/tests/unit/modules/test_netbox.py", line 86, in test_token_present
    netbox.get_('dcim', 'devices', name='test')
  File "/Users/tstrickx/Documents/Projects/salt/salt/modules/netbox.py", line 191, in get_
    return _dict(_get(app, endpoint, id=id, auth_required=True if app in AUTH_ENDPOINTS else False, **kwargs))
  File "/Users/tstrickx/Documents/Projects/salt/salt/modules/netbox.py", line 128, in _get
    kwargs = __utils__['args.clean_kwargs'](**kwargs)
KeyError: u'args.clean_kwargs'

[gtmanfred]

Are you using this on 2017.7 or older? because the args.py file was added starting in 2018.3.

[gtmanfred]

you would need to include the args.py in your salt://_utils as well for older versions.

[Ichabond]

This happened while running the unit tests using ./runtests.py --name=unit.modules.test_netbox. Not sure how that relates to which version of Salt I'm running.
Maybe this is relevant?

pytest-salt (2018.2.2)          - Pytest Salt Plugin
  INSTALLED: 2018.2.2 (latest)

[gtmanfred]

__utils__['dictupdate.update']()

[cachedout]

We like to avoid the use of **kwargs because it's unclear to the end user what it supposed to be passed here. We either need this made into an explicit variable or an explanation of what's expected here inserted into the function documentation, please.

[Ichabond]

Done.

[cachedout]

This is duplicated in a few places. Can we refactor it into a single location?

[Ichabond]

What do you mean exactly?

[Ichabond]

From what I understood, you want to refactor the "does this object exist in netbox" checks to a single location. Most of these checks are single use, except for the device one, which I guess could be put in a function. Is this what you meant?

[cachedout]

Same here. DRY?

[cachedout]

Should we just make the empty strings the keyword defaults?

[Ichabond]

Done

[Ichabond]

I have made the requested changes, and updated the tests to function. Please let me know if there's anything else that needs to be done before merging.

[rallytime]

This looks good to me. Thanks for updating this.

[Ichabond]

I changed the branch to Fluorine. CC @rallytime

[rallytime]

Thanks @Ichabond! And congrats on your first Salt PR!