Add new google_chat module #48919
Add new google_chat module #48919
Conversation
luke-orden
force-pushed
the
add_google_chat
branch
from
f08a1ed to
51719bc
Compare
cachedout
left a comment
cachedout
left a comment
There was a problem hiding this comment.
Excellent! Before we merge this, would you mind adding information about this new feature to the release notes?
gtmanfred
left a comment
gtmanfred
left a comment
There was a problem hiding this comment.
Just one nitpick change.
Otherwise this looks good.
salt/modules/google_chat.py
Outdated
There was a problem hiding this comment.
instead of importing salt.utils.http, please use __utils__['http.query']()
salt/modules/google_chat.py
Outdated
There was a problem hiding this comment.
Can you add print_function and unicode_literals to this __future__ import? We need that for PY2/PY3 compatibility. :)
luke-orden
force-pushed
the
add_google_chat
branch
from
51719bc to
3636897
Compare
|
@loverend If you could add this to the Fluorine release notes we can get this in pending tests. :) Thanks for this addition! |
luke-orden
force-pushed
the
add_google_chat
branch
2 times, most recently
from
873e105 to
fe615d8
Compare
|
Added to release notes. There wasn't a |
|
@loverend Some of your new tests are having some trouble here. Can you take a look? https://jenkinsci.saltstack.com/job/pr-kitchen-ubuntu1604-py2/job/PR-48919/5/ |
luke-orden
force-pushed
the
add_google_chat
branch
4 times, most recently
from
9904e4c to
ae0b5a3
Compare
To send a message directly to google chat via the api (not via a bot) you need to configure a webhook and post directly to that webhook url.
luke-orden
force-pushed
the
add_google_chat
branch
from
ae0b5a3 to
969d7d6
Compare
|
All tests now pass. I have addressed all comments. Please let me know if there are any further changes required. |
gtmanfred
left a comment
gtmanfred
left a comment
There was a problem hiding this comment.
Awesome! thanks for this! looks great.
6 participants
What does this PR do?
Add a new
google_chatmodule which allows you to send a message to a google chat room.What issues does this PR fix or reference?
N/A
New Behavior
Send a message to a google chat room
Tests written?
Yes
Commits signed with GPG?
Yes