New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 salt-key fixes #48929

Merged
merged 1 commit into from Aug 9, 2018

Conversation

Projects
None yet
3 participants
@terminalmage
Member

terminalmage commented Aug 3, 2018

This fixes the following two issues:

  1. Default values were not properly being pulled from the argspec.
  2. Minion IDs with = in them were not handled properly as they were
    assumed to be keyword args.

Fixes #48496.

2 salt-key fixes
This fixes the following two issues:

1. Default values were not properly being pulled from the argspec.
2. Minion IDs with `=` in them were not handled properly as they were
   assumed to be keyword args.

@rallytime rallytime requested a review from DmitryKuzmenko Aug 5, 2018

@DmitryKuzmenko

👍

@rallytime rallytime requested a review from cachedout Aug 6, 2018

@rallytime rallytime merged commit 2a38905 into saltstack:2018.3 Aug 9, 2018

6 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@terminalmage terminalmage deleted the terminalmage:issue48496 branch Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment