New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fix to scheduler when global enabled key is present #49019

Merged
merged 2 commits into from Aug 9, 2018

Conversation

Projects
None yet
2 participants
@garethgreenaway
Member

garethgreenaway commented Aug 8, 2018

What does this PR do?

Fixing a bug that occurs if the global "enabled" key is present in the scheduler items dictionary.
Adding a test to ensure scheduler runs as expected when that key is present.

What issues does this PR fix or reference?

#47695

Tests written?

Yes

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Fixing a bug that occurs if the "enabled" key is present in the sched…
…uler items dictionary. Adding a test to ensure scheduler runs as expected when that key is present.
@rallytime

This comment has been minimized.

Contributor

rallytime commented Aug 8, 2018

@rallytime rallytime merged commit d353c02 into saltstack:2018.3 Aug 9, 2018

4 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment