New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grains integration test more robust #49020

Merged
merged 1 commit into from Aug 8, 2018

Conversation

Projects
None yet
2 participants
@rallytime
Contributor

rallytime commented Aug 8, 2018

The test_grains_append_val_already_present test can be flaky, especially on CentOS 7 when it gets bogged down. Let's give the test a little breathing room by adding a sleep so the grains.append calls don't stack up too quickly.

Fixes saltstack/salt-jenkins#1052

Make grains integration test more robust
The `test_grains_append_val_already_present` test can be flaky, especially on
CentOS 7 when it gets bogged down. Let's give the test a little breathing room
by adding a sleep so the grains.append calls don't stack up too quickly.

@rallytime rallytime requested a review from Ch3LL Aug 8, 2018

@Ch3LL

Ch3LL approved these changes Aug 8, 2018

@rallytime rallytime merged commit 6b6d68c into saltstack:2017.7.8 Aug 8, 2018

6 of 8 checks passed

jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details

@rallytime rallytime deleted the rallytime:fix-grains-test branch Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment