Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several issues with LGPO #49025

Merged
merged 2 commits into from Aug 31, 2018

Conversation

Projects
None yet
4 participants
@twangboy
Copy link
Contributor

commented Aug 8, 2018

What does this PR do?

Fixes an issue with the state where the comments field wasn't being commented properly

Fixes an issue in the state module where it was detecting that it needed to change a policy that had a list of users. The two lists were the same but in differing orders.

Fixes an issue with the module where it was stack tracing when setting "Devices: Allowed to format..." to Not Defined

What issues does this PR fix or reference?

#48661

Tests written?

No

Commits signed with GPG?

Yes

Fix several issues with LGPO
Fixes an issue with the state where the comments field wasn't being
commented properly
Fixes an issue with the module where it was stack tracing when setting
"Devices: Allowed to format..." to Not Defined
Fixes an issue in the state module where it was detecting that it needed
to change a policy that had a list of users. The two lists were the same
but in differing orders.

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Aug 8, 2018

@twangboy twangboy requested review from lomeroe and saltstack/team-windows and removed request for saltstack/team-windows Aug 8, 2018

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Aug 17, 2018

@dwoz Can you review this today?

@dwoz

dwoz approved these changes Aug 21, 2018

Copy link
Contributor

left a comment

Looks good, I'm going to re-run the py2 tests.

@twangboy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2018

@lomeroe Would you mind taking a look at this?

@twangboy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2018

@lomeroe ping

@twangboy twangboy closed this Aug 29, 2018

@twangboy twangboy reopened this Aug 29, 2018

@rallytime rallytime merged commit 4ea22e5 into saltstack:2018.3 Aug 31, 2018

7 of 8 checks passed

jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@twangboy twangboy deleted the twangboy:fix_48661 branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.