New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file.get_diff for remote files #49033

Merged
merged 2 commits into from Aug 9, 2018

Conversation

Projects
None yet
2 participants
@terminalmage
Member

terminalmage commented Aug 9, 2018

Once the files were cached, the function was still trying to open the paths passed into it, not the cached paths. This fixes that and adds additional unit tests.

Fixes #48996.

Fix file.get_diff for remote files
Once the files were cached, the function was still trying to open the
paths passed into it, not the cached paths. This fixes that and adds
additional unit tests.

@rallytime rallytime merged commit 4eeb75f into saltstack:2018.3 Aug 9, 2018

4 of 7 checks passed

jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
continuous-integration/jenkins/pr-merge This commit is being built
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details

@terminalmage terminalmage deleted the terminalmage:issue48996 branch Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment