Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update win_pkg.py #49039

Merged
merged 1 commit into from Aug 9, 2018

Conversation

@stratusjerry
Copy link
Contributor

commented Aug 9, 2018

Fix path and other typos

What does this PR do?

Fixes documentation for pathing and 2 other typos

What issues does this PR fix or reference?

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Tests written?

Yes/No

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Fix path and other typos
@salt-jenkins salt-jenkins requested review from saltstack/team-windows Aug 9, 2018
Copy link
Contributor

left a comment

Thanks for updating this @stratusjerry! And welcome!

@rallytime rallytime merged commit 2b623e0 into saltstack:develop Aug 9, 2018
5 of 9 checks passed
5 of 9 checks passed
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
@stratusjerry

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

@rallytime can this be backported to 2018 and 2019?

@twangboy

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2019

@stratusjerry Sure, can you create a Pull Request?

This was referenced Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.