New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for the registry module and state #49045

Merged
merged 3 commits into from Aug 13, 2018

Conversation

Projects
None yet
3 participants
@twangboy
Contributor

twangboy commented Aug 9, 2018

What does this PR do?

Addresses discrepancies about when you should double, single, and not quote the hive/key parameters

What issues does this PR fix or reference?

#43164

Tests written?

No

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Aug 9, 2018

@rallytime

I have some small requests, otherwise 👍

There are some lint errors that need to be fixed, too: https://jenkinsci.saltstack.com/job/pr-lint/job/PR-49045/1/warnings52Result/

@@ -18,6 +18,17 @@
Keys are the folders in the registry. Keys can have many nested subkeys. Keys
can have a value assigned to them under the (Default)
When passing key on the CLI it must be quoted correctly depending on the

This comment has been minimized.

@rallytime

rallytime Aug 10, 2018

Contributor

When passing a key

This comment has been minimized.

@twangboy

twangboy Aug 10, 2018

Contributor

OK

Using single backslashes:
``"SOFTWARE\Python"``
``'SOFTWARE\Python' (will not work on a Windows Master)``

This comment has been minimized.

@rallytime

rallytime Aug 10, 2018

Contributor

I think it would make more sense to move the parentheses part outside of the backticks.:
'SOFWARE\Python' (will not work on a Windows Master)

This comment has been minimized.

@twangboy

twangboy Aug 10, 2018

Contributor

Yeah, I'll fix that

@twangboy

This comment has been minimized.

Contributor

twangboy commented Aug 10, 2018

@rallytime Getting a 502 error on the lint link. Do you happen to know what the issue was?

twangboy added some commits Aug 9, 2018

Fix docs for the registry module and state
Addresses discrepencies about when you should double, single, and not
quote the hive/key parameters

@twangboy twangboy force-pushed the twangboy:fix_43164 branch from c5e58d1 to e792435 Aug 10, 2018

@rallytime

This comment has been minimized.

Using single backslashes:
``"SOFTWARE\Python"``
``'SOFTWARE\Python'`` (will not work on a Windows Master)

This comment has been minimized.

@cachedout

cachedout Aug 10, 2018

Contributor

Huh? Why won't it work on a master?

This comment has been minimized.

@twangboy

twangboy Aug 11, 2018

Contributor

The cmd line on Windows doesn't like single quotes.

@rallytime rallytime merged commit af6ec1d into saltstack:2017.7 Aug 13, 2018

8 checks passed

WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@twangboy twangboy deleted the twangboy:fix_43164 branch Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment