New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out scheme's that are not valid #49087

Merged
merged 1 commit into from Aug 13, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Contributor

dwoz commented Aug 13, 2018

What does this PR do?

We don't want to honor schemes that are not valid an example of this is
a string like 'c:\foo' will have a scheme of 'c' after being parsed.

This will fix multiple failing tests in integration.states.test_file.

Tests written?

No - Fixing existing tests

Commits signed with GPG?

Yes

Filter out scheme's that are not valid
We don't want to honor schemes that are not valid an example of this is
a string like 'c:\\foo' will have a scheme of 'c' after being parsed.

@dwoz dwoz requested a review from rallytime Aug 13, 2018

@dwoz dwoz merged commit 274977b into saltstack:2017.7 Aug 13, 2018

8 checks passed

WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

dwoz added a commit to dwoz/salt that referenced this pull request Aug 14, 2018

Multiple fixes for integration.states.test_file
- Fix wart in PR saltstack#49087 file://c:\foo\bar vs c:\foo\bar local paths
- Finalize fix for test_issue_8343_accumulated_require_in
- Fix wart in PR saltstack#49088 Ignore proper directory test

dwoz added a commit to dwoz/salt that referenced this pull request Aug 14, 2018

Multiple fixes for integration.states.test_file
- Fix wart in PR saltstack#49087 file://c:\foo\bar vs c:\foo\bar local paths
- Finalize fix for test_issue_8343_accumulated_require_in
- Fix wart in PR saltstack#49088 Ignore proper directory test

Ch3LL added a commit to Ch3LL/salt that referenced this pull request Aug 17, 2018

Multiple fixes for integration.states.test_file
- Fix wart in PR saltstack#49087 file://c:\foo\bar vs c:\foo\bar local paths
- Finalize fix for test_issue_8343_accumulated_require_in
- Fix wart in PR saltstack#49088 Ignore proper directory test

@dwoz dwoz deleted the dwoz:url_file_test_fixes branch Aug 21, 2018

dwoz added a commit to dwoz/salt that referenced this pull request Aug 22, 2018

Merge pull request saltstack#49087 from dwoz/url_file_test_fixes
Filter out scheme's that are not valid

dwoz added a commit to dwoz/salt that referenced this pull request Aug 22, 2018

Multiple fixes for integration.states.test_file
- Fix wart in PR saltstack#49087 file://c:\foo\bar vs c:\foo\bar local paths
- Finalize fix for test_issue_8343_accumulated_require_in
- Fix wart in PR saltstack#49088 Ignore proper directory test

dwoz added a commit to dwoz/salt that referenced this pull request Aug 22, 2018

Merge pull request saltstack#49087 from dwoz/url_file_test_fixes
Filter out scheme's that are not valid

dwoz added a commit to dwoz/salt that referenced this pull request Aug 22, 2018

Multiple fixes for integration.states.test_file
- Fix wart in PR saltstack#49087 file://c:\foo\bar vs c:\foo\bar local paths
- Finalize fix for test_issue_8343_accumulated_require_in
- Fix wart in PR saltstack#49088 Ignore proper directory test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment