Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[fluorine] Fixes to scheduler for jobs with seconds, minutes, etc. #49104
What does this PR do?
Do not log about various things like jid_include and max_running unless the job is set to run. If the job contains _seconds, eg. it's using seconds, minutes, hours, etc. then only set the _next_fire_time if the job actually runs. Adding more tests to test simple scenarios when seconds, minutes, hours and days to ensure we get multiple scheduled job runs when they're expected to run.
What issues does this PR fix or reference?
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
pizzapanther left a comment
A couple findings. First in enterprise we use salt as a python import when calculating schedules and there looks to be a loading issue:
My guess is you are loading
Anyways I couldn't get it to work right with out a little hacking. But once I worked around the loader and got it calculating schedules and there are big differences.
I'm thinking maybe we submit some of the enterprise code for a unit test on the scheduler so you can see how we use it. I put some work arounds in to use it for our use case. Maybe we need to use it more "properly" or also this change might have broken the calculation too much.