New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows installer script #49116

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
2 participants
@twangboy
Contributor

twangboy commented Aug 14, 2018

What does this PR do?

Adds the /nonfatal switch to the file command for VCRedist

We used to include the VCredist for the Py3 build on Windows. It is not necessary since Py3 includes the required DLL. Additionally, the vcredist installation resulted in a corrupt installation of vcredist in random instances. So, we removed it.

The installer script was failing when it couldn't find the vcredist file (the line is still needed for the Py2 installation). So, we added the /nonfatal switch to the file command.

What issues does this PR fix or reference?

Found during build

Tests written?

NA

Commits signed with GPG?

Yes

@rallytime rallytime merged commit e484f26 into saltstack:2017.7.8 Aug 14, 2018

4 of 8 checks passed

jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details

@twangboy twangboy deleted the twangboy:fix_installer branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment