Add pathstate to keepalive check in mac_service #49121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The following tests:
are failing on macosx after this PR: #46206
The service we use in our test suite sets keepalive with PathState setting. From the launchd docs there are also other ways to set keepalive besides just setting it to be True. This PR only handles PathState so more cases will need to be added. I moved the
_always_running_servicecheck after we check for pids to try to retain backwards compatibility. If the service actually returns a pid we return that and not loaded if the check for KeepAlive is not added to the code yet.