Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return of tls.cert_info extensions #49123

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
1 participant
@The-Loeki
Copy link
Contributor

commented Aug 14, 2018

extension keys in tls.cert_info return are still in b'' because OpenSSL's return is not fixxed.

Previous Behavior

[root@testbak1 ~]# salt-call --local tls.cert_info /etc/vault/ca.pem                                                                                                                                               
local:                                                                                                                                                                                                             
    ----------                                                                                                                                                                                                     
    extensions:                                                                                                                                                                                                    
        ----------                                                                                                                                                                                                 
        b'basicConstraints':                                                                                                                                                                                       
            CA:TRUE                                                                                                                                                                                                
        b'keyUsage':                                                                                                                                                                                               
            Certificate Sign, CRL Sign                                                                                                                                                                             

New Behavior

local:
    ----------
    extensions:
        ----------
        extendedKeyUsage:
            TLS Web Server Authentication, TLS Web Client Authentication
Fix return of tls.cert_info extensions
extension keys in tls.cert_info return are still in `b''` because OpenSSL's return is not fixxed.

@The-Loeki The-Loeki closed this Aug 14, 2018

@The-Loeki The-Loeki referenced this pull request Aug 14, 2018

Merged

TLS cert_info fixes #49126

@The-Loeki The-Loeki deleted the The-Loeki:patch-1 branch Aug 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.