Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the __utils__ dunder in Grains modules #49128

Merged
merged 1 commit into from Aug 15, 2018

Conversation

mirceaulinic
Copy link
Member

@mirceaulinic mirceaulinic commented Aug 15, 2018

What does this PR do?

Allows having __utils__ in Grains modules.

Previous Behavior

Unable to use a custom utils module.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@mirceaulinic mirceaulinic requested a review from as a code owner Aug 15, 2018
Copy link
Contributor

@cachedout cachedout left a comment

This makes a lot of sense. Thanks, @mirceaulinic

@gtmanfred gtmanfred merged commit 0faff8f into saltstack:develop Aug 15, 2018
7 of 9 checks passed
@mirceaulinic mirceaulinic deleted the grains-utils-dunder branch Aug 15, 2018
@waynew waynew added this to PR needs port to master in PRs to port to master Oct 24, 2019
@max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Nov 1, 2019

@mirceaulinic Hey! Are you going to backport this feature to master branch?

@mirceaulinic
Copy link
Member Author

@mirceaulinic mirceaulinic commented Nov 1, 2019

Hey @max-arnold. I'd be glad to port it, but I'm very surprised this code didn't make it given that's been merged a long time ago. My understanding is that it should have been included in 2019.2.0 at least, then 2019.2.1 as well, which is what SaltStack considers as stable. So now I'm just confused how on earth this is not there yet?

@max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Nov 1, 2019

It was merged to neon but, after the test stabilization efforts in 2019.2.1, the neon branch isn't going to be released as is and instead all the PRs need to be ported to the master. See the new development policy and the porting tracking project:

They explained this in more details during the office hours call on Oct 29, but I can't find the recording. Eventually they plan to port all the PRs from Neon on top of the new master branch, but I guess not everything will be ported on time for the next major release.

@max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Nov 16, 2019

Ok, I went ahead and ported it: #55336

dwoz added a commit that referenced this issue Jan 2, 2020
[master] Allow the __utils__ dunder in Grains modules (port #49128)
@garethgreenaway garethgreenaway moved this from PR needs port to master to PR has port to master in PRs to port to master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PRs to port to master
  
PR has port to master
Development

Successfully merging this pull request may close these issues.

None yet

5 participants