Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for normalized dirs in unit tests #49179

Merged
merged 2 commits into from Aug 18, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Copy link
Contributor

commented Aug 17, 2018

What does this PR do?

Account for normalized directory names in unit tests, fixes:

unit.states.test_file.TestFileState.test_directory
unit.states.test_file.TestFileState.test_recurse

Tests written?

No - Fixing tests

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from gtmanfred Aug 17, 2018

@dwoz dwoz changed the title Account for normalized dirs in unit tests [WIP] Account for normalized dirs in unit tests Aug 17, 2018

@dwoz dwoz changed the title [WIP] Account for normalized dirs in unit tests Account for normalized dirs in unit tests Aug 17, 2018

@dwoz dwoz merged commit b510441 into saltstack:2017.7 Aug 18, 2018

6 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details

@dwoz dwoz deleted the dwoz:test_unit_states_file branch Aug 21, 2018

dwoz added a commit to dwoz/salt that referenced this pull request Aug 22, 2018

Merge pull request saltstack#49179 from dwoz/test_unit_states_file
Account for normalized dirs in unit tests

dwoz added a commit to dwoz/salt that referenced this pull request Aug 22, 2018

Merge pull request saltstack#49179 from dwoz/test_unit_states_file
Account for normalized dirs in unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.