New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hanging syndic test #49182

Merged
merged 1 commit into from Aug 18, 2018

Conversation

Projects
None yet
3 participants
@terminalmage
Member

terminalmage commented Aug 17, 2018

There was no syndic_master and the fallback DNS lookup failed. This caused a traceback which hung the test suite.

Refs: saltstack/salt-jenkins#1078

This may not be the best solution, the best solution may be to add the config option in the test itself rather than in tests/integration/__init__.py. We'll have to see how it affects the rest of the test suite, if it affects it at all.

Fix hanging syndic test
There was no `syndic_master` and the fallback DNS lookup failed. This
caused a traceback which hung the test suite.

@cachedout cachedout merged commit 134f125 into saltstack:2018.3.3 Aug 18, 2018

5 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@terminalmage terminalmage deleted the terminalmage:salt-jenkins-1078 branch Aug 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment