Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode_reponses=True on all Redis API interfaces #49190

Merged
merged 3 commits into from Aug 20, 2018

Conversation

Projects
None yet
5 participants
@The-Loeki
Copy link
Contributor

commented Aug 18, 2018

What does this PR do?

Set decode_responses=True on all instantiations of the Redis API.
See discussion in #49060

What issues does this PR fix or reference?

fixes #49060

Previous Behavior

Some Redis returns were in binary

New Behavior

All Redis returns are in unicode

@The-Loeki The-Loeki requested a review from saltstack/team-core as a code owner Aug 18, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-suse Aug 18, 2018

@dwoz dwoz requested a review from terminalmage Aug 19, 2018

@dwoz

dwoz approved these changes Aug 19, 2018

@DmitryKuzmenko
Copy link
Contributor

left a comment

LGTM

@gtmanfred gtmanfred merged commit d29af00 into saltstack:2018.3 Aug 20, 2018

7 of 8 checks passed

jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@The-Loeki The-Loeki deleted the The-Loeki:redis-fix branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.