Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make salt.utils.vault._get_connection publicly available #49191

Merged
merged 1 commit into from Aug 19, 2018

Conversation

Projects
None yet
2 participants
@The-Loeki
Copy link
Contributor

commented Aug 18, 2018

What does this PR do?

salt.utils.vault._get_connection -> salt.utils.vault.get_connection

What issues does this PR fix or reference?

While writing some addon Vault functionality, we want to bypass the Salt vault module and use hvac.
To initialize it within Salt consistently, it makes sense to unhide this function to allow this and other integrations to easily reuse this piece of logic.

@dwoz

dwoz approved these changes Aug 19, 2018

@dwoz dwoz merged commit 63cc737 into saltstack:2018.3 Aug 19, 2018

5 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details

@The-Loeki The-Loeki deleted the The-Loeki:vault_publ_conn branch Aug 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.