Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't blow up check_perms if lsattr file doesn't exist #49209

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
3 participants
@gtmanfred
Copy link
Contributor

commented Aug 20, 2018

What issues does this PR fix or reference?

Fixes #49204

Tests written?

No

Commits signed with GPG?

Yes

@gtmanfred gtmanfred merged commit a4c51a9 into saltstack:2018.3 Aug 20, 2018

6 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@gtmanfred gtmanfred deleted the gtmanfred:lsattr branch Aug 20, 2018

try:
lattrs = lsattr(name)
except SaltInvocationError:
lsattrs = None

This comment has been minimized.

Copy link
@dgmorrisjr

dgmorrisjr Sep 25, 2018

lattrs is mis-spelled in this line. if the except condition fires, then following if lattrs is not None: line will throw an local variable 'lattrs' referenced before assignment error.

This comment has been minimized.

Copy link
@gtmanfred

gtmanfred Sep 25, 2018

Author Contributor

can you open a pr for this?

@dgmorrisjr

This comment has been minimized.

Copy link

commented Sep 28, 2018

@dgmorrisjr

This comment has been minimized.

Copy link

commented Sep 28, 2018

created pull request #49827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.