Set a nonzero retcode when minions fail to return #49217
ghost self-requested a review
Aug 20, 2018
terminalmage added a commit to terminalmage/salt that referenced this issue
Aug 21, 2018
saltstack#49217 added references to this value in the module, but the module isn't imported. It happened to already be imported elsewhere, but that was just a stroke of luck. This makes the import explicit to avoid changes elsewhere in the codebase causing these tests to suddenly start failing.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.