Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a nonzero retcode when minions fail to return #49217

Merged
merged 2 commits into from Aug 21, 2018

Conversation

Projects
None yet
4 participants
@terminalmage
Copy link
Contributor

commented Aug 20, 2018

This PR has been opened against fluorine since that is where the rest of the recent exit codes work has been done.

Fixes #47235.

@terminalmage terminalmage requested a review from saltstack/team-core as a code owner Aug 20, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-suse Aug 20, 2018

@terminalmage terminalmage requested a review from cachedout Aug 20, 2018

@terminalmage terminalmage force-pushed the terminalmage:issue47235 branch from c5ab8d5 to 3c1632d Aug 20, 2018

@isbm

isbm approved these changes Aug 21, 2018

@gtmanfred gtmanfred merged commit d2f6647 into saltstack:fluorine Aug 21, 2018

5 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details

terminalmage added a commit to terminalmage/salt that referenced this pull request Aug 21, 2018

Make sure salt.defaults.exitcodes is imported in saltcli tests
saltstack#49217 added references to this
value in the module, but the module isn't imported. It happened to
already be imported elsewhere, but that was just a stroke of luck. This
makes the import explicit to avoid changes elsewhere in the codebase
causing these tests to suddenly start failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.