Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a nonzero retcode when minions fail to return #49217

Merged
merged 2 commits into from Aug 21, 2018

Conversation

@terminalmage
Copy link
Collaborator

@terminalmage terminalmage commented Aug 20, 2018

This PR has been opened against fluorine since that is where the rest of the recent exit codes work has been done.

Fixes #47235.

isbm
isbm approved these changes Aug 21, 2018
@gtmanfred gtmanfred merged commit d2f6647 into saltstack:fluorine Aug 21, 2018
5 of 8 checks passed
terminalmage added a commit to terminalmage/salt that referenced this issue Aug 21, 2018
saltstack#49217 added references to this
value in the module, but the module isn't imported. It happened to
already be imported elsewhere, but that was just a stroke of luck. This
makes the import explicit to avoid changes elsewhere in the codebase
causing these tests to suddenly start failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants