Set a nonzero retcode when minions fail to return#49217
Merged
gtmanfred merged 2 commits intosaltstack:fluorinefrom Aug 21, 2018
Merged
Set a nonzero retcode when minions fail to return#49217gtmanfred merged 2 commits intosaltstack:fluorinefrom
gtmanfred merged 2 commits intosaltstack:fluorinefrom
Conversation
ghost
self-requested a review
gtmanfred
approved these changes
Aug 20, 2018
terminalmage
force-pushed
the
issue47235
branch
from
c5ab8d5 to
3c1632d
Compare
isbm
approved these changes
Aug 21, 2018
cachedout
approved these changes
Aug 21, 2018
terminalmage
added a commit
to terminalmage/salt
that referenced
this pull request
Aug 21, 2018
saltstack#49217 added references to this value in the module, but the module isn't imported. It happened to already be imported elsewhere, but that was just a stroke of luck. This makes the import explicit to avoid changes elsewhere in the codebase causing these tests to suddenly start failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been opened against fluorine since that is where the rest of the recent exit codes work has been done.
Fixes #47235.