New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows and OSX installers #49218

Merged
merged 3 commits into from Aug 21, 2018

Conversation

Projects
None yet
2 participants
@twangboy
Contributor

twangboy commented Aug 20, 2018

What does this PR do?

Adds support to Universal C Runtime Libraries (UCRT) for Windows
Adds futures to the req.txt for OSX

What issues does this PR fix or reference?

Found in testing

Previous Behavior

On fresh versions of Windows 8.1 and below the minion would fail to start on Py3 installs due to missing Universal C Runtime Support
Also an issue with futures missing on Mac installations

Tests written?

NA

Commits signed with GPG?

Yes

Fix Windows and OSX installers
Adds support to Universal Runtime Libraries (UCRT) for Windows
Adds futures to the req.txt for OSX

@twangboy twangboy requested a review from dwoz Aug 20, 2018

twangboy added some commits Aug 20, 2018

@dwoz

dwoz approved these changes Aug 20, 2018

@dwoz dwoz merged commit 0eb6ddf into saltstack:2017.7.8 Aug 21, 2018

8 checks passed

WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@twangboy twangboy deleted the twangboy:fix_installer branch Aug 23, 2018

@twangboy twangboy referenced this pull request Aug 23, 2018

Merged

Fix installer 2018.3.3 #49302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment