Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for mandatory parameters for `mount.mounted` #49231

Merged
merged 2 commits into from Aug 22, 2018

Conversation

Projects
None yet
3 participants
@minusf
Copy link
Contributor

commented Aug 21, 2018

What does this PR do?

Check for mandatory parameters for mount.mounted

What issues does this PR fix or reference?

#49230

Previous Behavior

false positive when passed empty parameters

New Behavior

return error

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dwoz

dwoz approved these changes Aug 22, 2018

@dwoz dwoz requested a review from cachedout Aug 22, 2018

@cachedout cachedout merged commit 62cc0df into saltstack:2017.7 Aug 22, 2018

8 checks passed

WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.