New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use yaml's safe_dump in windows ec2 tests #49239

Merged
merged 2 commits into from Aug 22, 2018

Conversation

Projects
None yet
2 participants
@Ch3LL
Contributor

Ch3LL commented Aug 21, 2018

What does this PR do?

the tests:

integration.cloud.providers.test_ec2.EC2Test.test_win2012r2_winrm
integration.cloud.providers.test_ec2.EC2Test.test_win2016_winrm

are failing because a !!python/unicode tag is getting added to the configuration file. So when we go to the next test and it tries to read the file we see this error:

ConstructorError: could not determine a constructor for the tag 'tag:yaml.org,2002:python/unicode'

changing to a safe_dump to make sure we are not producing python tags.

What issues does this PR fix or reference?

fixes saltstack/salt-jenkins#1064

Ch3LL added some commits Aug 21, 2018

@dwoz dwoz self-requested a review Aug 21, 2018

@dwoz

dwoz approved these changes Aug 22, 2018

@dwoz dwoz merged commit 0fb9ccf into saltstack:2018.3.3 Aug 22, 2018

6 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment