Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockreplace better fix #49242

Merged
merged 4 commits into from Aug 22, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Copy link
Contributor

commented Aug 21, 2018

What does this PR do?

Revert my changes to blockreplace tests in favor of @twangboy's fix which also matches the 2018.3 branch.

Tests written?

No - Fixing tests

Commits signed with GPG?

Yes

twangboy and others added some commits Aug 21, 2018

@cachedout cachedout merged commit d55d484 into saltstack:2017.7 Aug 22, 2018

7 of 8 checks passed

jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details

@dwoz dwoz deleted the dwoz:blockreplace_better_fix branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.