Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip ID 7 for vmware hard drives #49253

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
4 participants
@gtmanfred
Copy link
Contributor

commented Aug 22, 2018

What does this PR do?

Skip 7 as the id for vmware hard disks, because it is reserved to the SCSI Controller

Same from our friends.

https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/vmware/vmware_guest.py#L670

Tests written?

Yes

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested a review from saltstack/team-cloud Aug 22, 2018

@gtmanfred

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2018

Waiting for @grichmond-salt to verify that this actually fixes the issue for $customer.

@cachedout
Copy link
Collaborator

left a comment

Some lint fixup is needed on this.

@gtmanfred gtmanfred force-pushed the gtmanfred:vmware branch from b4ce489 to b7c8681 Aug 22, 2018

@gtmanfred gtmanfred force-pushed the gtmanfred:vmware branch from b7c8681 to 6e776ca Aug 22, 2018

@grichmond-salt

This comment has been minimized.

Copy link

commented Aug 22, 2018

The suggested fix works. Please proceed. Would be nice for this to be back-ported to 2017.7, also.
Thanks, @gtmanfred!

@gtmanfred gtmanfred merged commit f6b2b93 into saltstack:2018.3 Aug 23, 2018

3 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details

rallytime added a commit that referenced this pull request Aug 23, 2018

@gtmanfred gtmanfred deleted the gtmanfred:vmware branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.