Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend #48588 to cover SyncAuth class #49262

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
3 participants
@mattp-
Copy link
Contributor

commented Aug 22, 2018

What does this PR do?

The original fix in #48588 was only covered asyncauth, but the syncauth method overrode the fix. This patch duplicates it so behavior should be consistent in both codepaths.

What issues does this PR fix or reference?

#48415

Tests written?

No

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

extend #488588 to cover SyncAuth class
the original fix was only covered asyncauth, but the syncauth method overrode
the fix. This patch duplicates it so behavior should be consistent in both
codepaths.

@mattp- mattp- changed the title extend #488588 to cover SyncAuth class extend #48588 to cover SyncAuth class Aug 22, 2018

@gtmanfred gtmanfred merged commit 879c3ad into saltstack:2017.7 Aug 22, 2018

7 of 8 checks passed

jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.