New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 64 bit binaries for KB2999226 to the x86 installer #49272

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
3 participants
@twangboy
Contributor

twangboy commented Aug 23, 2018

What does this PR do?

Fix logic where it detects the Architecture of the system running the installer instead of the one building the installer
Add a 3 seconds pause to actually see the error code if it throws one

What issues does this PR fix or reference?

Found in QA

Tests written?

NA

Commits signed with GPG?

Yes

Add 64bit binaries for KB2999226 to the x86 installer
Fix logic where it detects the Architecture of the system running the
installer instead of the one building the installer
Add a 3 seconds pause to actually see the error code if it throws one
@dwoz

dwoz approved these changes Aug 23, 2018

@gtmanfred gtmanfred merged commit e0e8779 into saltstack:2017.7.8 Aug 23, 2018

8 checks passed

WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@twangboy twangboy deleted the twangboy:fix_installer_more branch Aug 23, 2018

@twangboy twangboy referenced this pull request Aug 23, 2018

Merged

Fix installer 2018.3.3 #49302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment