Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #49281 etcd_cache with mine cache #49283

Merged
merged 2 commits into from Aug 31, 2018

Conversation

Projects
None yet
4 participants
@aarnaud
Copy link
Contributor

commented Aug 23, 2018

Signed-off-by: Anthony ARNAUD github@anthony-arnaud.fr

What does this PR do?

Fix #49281 etcd_cache with mine cache

What issues does this PR fix or reference?

Previous Behavior

Mine cache doesn't work with etcd cache

New Behavior

It's worked

Tests written?

No

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@aarnaud aarnaud requested a review from saltstack/team-core as a code owner Aug 23, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-suse Aug 23, 2018

@aarnaud aarnaud force-pushed the aarnaud:fix-etcd-cache branch from 486d286 to a99d7ad Aug 23, 2018

Fix #49281 etcd_cache with mine cache
Signed-off-by: Anthony ARNAUD <github@anthony-arnaud.fr>

@aarnaud aarnaud force-pushed the aarnaud:fix-etcd-cache branch from a99d7ad to 6c0fb9c Aug 23, 2018

@gtmanfred

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2018

@FedericoCeratto as the author of this, can you just double check that this looks fine for you?

@brejoc

brejoc approved these changes Aug 31, 2018

Copy link
Member

left a comment

lgtm. Thanks @aarnaud!

@rallytime rallytime merged commit dd9ec94 into saltstack:2018.3 Aug 31, 2018

7 of 8 checks passed

jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
@rallytime

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2018

Welcome @aarnaud! Thank you for submitting this fix. :)

@aarnaud aarnaud deleted the aarnaud:fix-etcd-cache branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.