New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around cmd.run unicode issues in test for now #49299

Merged
merged 3 commits into from Aug 25, 2018

Conversation

Projects
None yet
4 participants
@dwoz
Contributor

dwoz commented Aug 23, 2018

Cat is missing on windows. I tired unsuccesfully to make this work with
the 'type' command on windows. This is maybe not ideal but it stablizes
the test suite for now.

Tests written?

No

Commits signed with GPG?

Yes

Work around cmd.run unicode issues in test for now
Cat is missing on windows. I tired unsuccesfully to make this work with
the 'type' command on windows. This is maybe not ideal but it stablizes
the test suite for now.

@dwoz dwoz requested a review from twangboy Aug 23, 2018

@damon-atkins

This comment has been minimized.

Member

damon-atkins commented Aug 24, 2018

Try 'type' but you might also need to do 'chcp 65001'

@dwoz

This comment has been minimized.

@dwoz dwoz changed the title from Work around cmd.run unicode issues in test for now to [WIP]Work around cmd.run unicode issues in test for now Aug 24, 2018

@dwoz dwoz changed the title from [WIP]Work around cmd.run unicode issues in test for now to [WIP] Work around cmd.run unicode issues in test for now Aug 24, 2018

@dwoz

This comment has been minimized.

Contributor

dwoz commented Aug 24, 2018

@damon-atkins For python 2 I think we still run into this:

#48880

The main purpose of this is to try and get the windows test suite stable so we can start running windows PR tests. We can tackle the cmd.run thing in another test specific to that issue. (or maybe we just drop py2 support ;))

@dwoz dwoz changed the title from [WIP] Work around cmd.run unicode issues in test for now to Work around cmd.run unicode issues in test for now Aug 24, 2018

@dwoz dwoz merged commit b47da0a into saltstack:2018.3 Aug 25, 2018

5 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details

rallytime added a commit that referenced this pull request Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment